Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SST with GPU support #3918

Merged
merged 2 commits into from
Nov 15, 2023
Merged

SST with GPU support #3918

merged 2 commits into from
Nov 15, 2023

Conversation

anagainaru
Copy link
Contributor

@anagainaru anagainaru commented Nov 14, 2023 •
edited
Loading

SST was using MallocV and not ChunkV for copying the memory to internal buffers (for small block not deferred) so it was seg faulting for simple examples.

There are two contributions brought by this PR:

  • Bug fix so that SST can use Cuda and Kokkos pointers
  • Add an example using directly Kokkos Views with SST

Closes #3706

eisenhauer
eisenhauer approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@eisenhauer eisenhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward MallocV tweak...

@anagainaru anagainaru enabled auto-merge November 14, 2023 23:30
@anagainaru anagainaru disabled auto-merge November 14, 2023 23:44
@anagainaru
Copy link
Contributor Author

anagainaru commented Nov 14, 2023 •
edited
Loading

Tests failing:

he following tests FAILED:
2023-11-14T23:41:09.2266194Z 	767 - Engine.BP.*/BPChangingShapeWithinStep.MultiBlock/*.BP3.MPI (Timeout)
2023-11-14T23:41:09.2267122Z 	769 - Engine.BP.*/BPChangingShapeWithinStep.MultiBlock/*.BP4.MPI (Timeout)

@anagainaru anagainaru enabled auto-merge November 14, 2023 23:59
@vicentebolea vicentebolea merged commit 413b6ca into ornladios:master Nov 15, 2023
29 of 32 checks passed
@anagainaru anagainaru deleted the sst-with-kokkos branch November 18, 2023 20:41
@BrewTestBot BrewTestBot mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eisenhauer eisenhauer eisenhauer approved these changes

@vicentebolea vicentebolea Awaiting requested review from vicentebolea vicentebolea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SST with GPU support
3 participants
@anagainaru @eisenhauer @vicentebolea